Skip to content

Update Heltec Automation(TM) boards defintion. #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update Heltec Automation(TM) boards defintion. #2392

wants to merge 1 commit into from

Conversation

Heltec-Aaron-Lee
Copy link
Contributor

Update Heltec Automation(TM) boards defintion, include WiFi_Kit_32, WiFi_LoRa_32, WiFi_LoRa_32_V2, Wireless_Stick defintions.

Please check.

@DasNordlicht DasNordlicht mentioned this pull request Feb 4, 2019
Closed
@stickbreaker
Copy link
Contributor

@Heltec-Aaron-Lee I would recommend you consider the other menu choices for these boards.

{variant}.menu.PartitionScheme.default=Default
{variant}.menu.PartitionScheme.default.build.partitions=default
{variant}.menu.PartitionScheme.minimal=Minimal (2MB FLASH)
{variant}.menu.PartitionScheme.minimal.build.partitions=minimal
{variant}.menu.PartitionScheme.no_ota=No OTA (Large APP)
{variant}.menu.PartitionScheme.no_ota.build.partitions=no_ota
{variant}.menu.PartitionScheme.no_ota.upload.maximum_size=2097152
{variant}.menu.PartitionScheme.huge_app=Huge APP (3MB No OTA)
{variant}.menu.PartitionScheme.huge_app.build.partitions=huge_app
{variant}.menu.PartitionScheme.huge_app.upload.maximum_size=3145728
{variant}.menu.PartitionScheme.min_spiffs=Minimal SPIFFS (Large APPS with OTA)
{variant}.menu.PartitionScheme.min_spiffs.build.partitions=min_spiffs
{variant}.menu.PartitionScheme.min_spiffs.upload.maximum_size=1966080
{variant}.menu.PartitionScheme.fatflash=16M Fat
{variant}.menu.PartitionScheme.fatflash.build.partitions=ffat

{variant}.menu.CPUFreq.240=240MHz (WiFi/BT)
{variant}.menu.CPUFreq.240.build.f_cpu=240000000L
{variant}.menu.CPUFreq.160=160MHz (WiFi/BT)
{variant}.menu.CPUFreq.160.build.f_cpu=160000000L
{variant}.menu.CPUFreq.80=80MHz (WiFi/BT)
{variant}.menu.CPUFreq.80.build.f_cpu=80000000L
{variant}.menu.CPUFreq.40=40MHz (40MHz XTAL)
{variant}.menu.CPUFreq.40.build.f_cpu=40000000L
{variant}.menu.CPUFreq.26=26MHz (26MHz XTAL)
{variant}.menu.CPUFreq.26.build.f_cpu=26000000L
{variant}.menu.CPUFreq.20=20MHz (40MHz XTAL)
{variant}.menu.CPUFreq.20.build.f_cpu=20000000L
{variant}.menu.CPUFreq.13=13MHz (26MHz XTAL)
{variant}.menu.CPUFreq.13.build.f_cpu=13000000L
{variant}.menu.CPUFreq.10=10MHz (40MHz XTAL)
{variant}.menu.CPUFreq.10.build.f_cpu=10000000L

{variant}.menu.FlashSize.4M=4MB (32Mb)
{variant}.menu.FlashSize.4M.build.flash_size=4MB
{variant}.menu.FlashSize.2M=2MB (16Mb)
{variant}.menu.FlashSize.2M.build.flash_size=2MB
{variant}.menu.FlashSize.2M.build.partitions=minimal
{variant}.menu.FlashSize.16M=16MB (128Mb)
{variant}.menu.FlashSize.16M.build.flash_size=16MB
{variant}.menu.FlashSize.16M.build.partitions=ffat

{variant}.menu.UploadSpeed.921600=921600
{variant}.menu.UploadSpeed.921600.upload.speed=921600
{variant}.menu.UploadSpeed.115200=115200
{variant}.menu.UploadSpeed.115200.upload.speed=115200
{variant}.menu.UploadSpeed.256000.windows=256000
{variant}.menu.UploadSpeed.256000.upload.speed=256000
{variant}.menu.UploadSpeed.230400.windows.upload.speed=256000
{variant}.menu.UploadSpeed.230400=230400
{variant}.menu.UploadSpeed.230400.upload.speed=230400
{variant}.menu.UploadSpeed.460800.linux=460800
{variant}.menu.UploadSpeed.460800.macosx=460800
{variant}.menu.UploadSpeed.460800.upload.speed=460800
{variant}.menu.UploadSpeed.512000.windows=512000
{variant}.menu.UploadSpeed.512000.upload.speed=512000

{variant}.menu.DebugLevel.none=None
{variant}.menu.DebugLevel.none.build.code_debug=0
{variant}.menu.DebugLevel.error=Error
{variant}.menu.DebugLevel.error.build.code_debug=1
{variant}.menu.DebugLevel.warn=Warn
{variant}.menu.DebugLevel.warn.build.code_debug=2
{variant}.menu.DebugLevel.info=Info
{variant}.menu.DebugLevel.info.build.code_debug=3
{variant}.menu.DebugLevel.debug=Debug
{variant}.menu.DebugLevel.debug.build.code_debug=4
{variant}.menu.DebugLevel.verbose=Verbose
{variant}.menu.DebugLevel.verbose.build.code_debug=5

@Heltec-Aaron-Lee
Copy link
Contributor Author

@stickbreaker should I undo this merge and undo again? or I can submission a new pull request it in the future update?

@stickbreaker
Copy link
Contributor

@Heltec-Aaron-Lee Just modify the effected files. The pr points to a specific branch. Just modify that branch.

@me-no-dev
Copy link
Member

I guess I will wait for the additions?

@me-no-dev me-no-dev mentioned this pull request Feb 14, 2019
Closed
@n9wxu
Copy link

n9wxu commented Feb 15, 2019

Please consider the modifications to the partition map for the board support. The board has a larger flash than the default 4MB. I included an 8MB partition map in pr #2407

@n9wxu
Copy link

n9wxu commented Feb 15, 2019

That was for the LoRa32 V2 hardware.

@Heltec-Aaron-Lee
Copy link
Contributor Author

@me-no-dev @n9wxu @stickbreaker I had submission a new push request #2470.

I think this version is fine :D

@me-no-dev
Copy link
Member

@Heltec-Aaron-Lee thanks! will close this one now :)

@n9wxu does the new PR cover your requirements?

@me-no-dev me-no-dev closed this Feb 18, 2019
n9wxu
n9wxu reviewed Feb 18, 2019
View reviewed changes
boards.txt
heltec_wifi_lora_32_V2.build.flash_mode=dio
heltec_wifi_lora_32_V2.build.flash_size=4MB
heltec_wifi_lora_32_V2.build.boot=dio
heltec_wifi_lora_32_V2.build.partitions=default
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default LoRa32 v2 has 8MB of flash and needs a different partition map. This can be found in PR #2407

n9wxu
n9wxu reviewed Feb 18, 2019
View reviewed changes
boards.txt

heltec_wifi_lora_32_V2.build.f_cpu=240000000L
heltec_wifi_lora_32_V2.build.flash_mode=dio
heltec_wifi_lora_32_V2.build.flash_size=4MB
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 8MB to cover the flash on the V2 HW.

Copy link
Contributor Author

@Heltec-Aaron-Lee Heltec-Aaron-Lee Feb 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your notice @n9wxu.

@me-no-dev I had submisson a new PR #2475, it's include a new partition map as @n9wxu suggested. This one is OK and I will close PR #2470

I think #2407 can be closed too.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n9wxu n9wxu n9wxu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Heltec-Aaron-Lee @stickbreaker @me-no-dev @n9wxu